Enhance debug logging for ReservableRequestConcurrencyControllers
#2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Provide more visibility for `ReservableRequestConcurrencyControllers` and how it changes internal state when new events received. Modifications: - Pass a connection to `ReservableRequestConcurrencyControllers` to always include connectionId when logging; - Log when retrying MaxConcurrentStreamsViolatedStacklessHttp2Exception; - Remove logging transport events from `AbstractLBHttpConnectionFactory` because we log it in `ReservableRequestConcurrencyControllers` now; Results: All `ReservableRequestConcurrencyControllers` logs contain connectionId.
bryce-anderson
approved these changes
Jul 5, 2023
...p-netty/src/main/java/io/servicetalk/http/netty/ReservableRequestConcurrencyControllers.java
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/ReservableRequestConcurrencyControllers.java
Show resolved
Hide resolved
...talk-http-netty/src/main/java/io/servicetalk/http/netty/AbstractLBHttpConnectionFactory.java
Show resolved
Hide resolved
bryce-anderson
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Provide more visibility for
ReservableRequestConcurrencyControllersand how it changes internal state when new events received.Modifications:
ReservableRequestConcurrencyControllersto always include connectionId when logging;AbstractLBHttpConnectionFactorybecause we log it inReservableRequestConcurrencyControllersnow;Results:
All
ReservableRequestConcurrencyControllerslogs contain connectionId.