RetryingHttpRequesterFilter use original Publisher avoid SOOE #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottmitch
force-pushed
the
retry_req_pub
branch
3 times, most recently
from
47d61c8
to
62b4017
Compare
| final Publisher<Object> originalMessageBody = request.messageBody(); | ||
| Single<StreamingHttpResponse> single = Single.defer(() -> (mayReplayRequestPayload ? | ||
| delegate.request(request.transformMessageBody(messageBodyDuplicator(originalMessageBody))) : | ||
| delegate.request(request.transformMessageBody(p -> originalMessageBody)) |
There was a problem hiding this comment.
When mayReplayRequestPayload == false, we don't need to do anything with originalMessageBody. Consider storing the reference and using defer only when mayReplayRequestPayload == true.
There was a problem hiding this comment.
When mayReplayRequestPayload == false, we don't need to do anything with originalMessageBody.
The unit test demonstrates the problem exists regardless of mayReplayRequestPayload. In either case if we don't restore the original publisher we will keep appending operators and eventually SOOE.
Scottmitch
force-pushed
the
retry_req_pub
branch
3 times, most recently
from
643a54e
to
f96202c
Compare
Scottmitch
commented
Aug 9, 2023
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/RedoPublisher.java
Outdated
Show resolved
Hide resolved
Scottmitch
force-pushed
the
retry_req_pub
branch
from
f96202c
to
f343a8e
Compare
Scottmitch
force-pushed
the
retry_req_pub
branch
from
f343a8e
to
2ced001
Compare
Motivation: RetryingHttpRequesterFilter uses the request across retry operations. The request's Publisher state is shared across retries and operators applied via transformMessageBody will therefore be reapplied on each retry. This typically isn't desirable from a semantics perspective but may also lead to StackOverflowException if enough retries are attempted. Modifications: - RetryingHttpRequesterFilter should reuse the original Publisher for request payload body on each retry attempt.
Scottmitch
force-pushed
the
retry_req_pub
branch
from
2ced001
to
0b6fcdf
Compare
bryce-anderson
approved these changes
Aug 10, 2023
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Single.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java
Outdated
Show resolved
Hide resolved
| @@ -37,7 +37,7 @@ public Single<StreamingHttpResponse> handle(final HttpServiceContext ctx, | |||
| final StreamingHttpRequest request, | |||
| final StreamingHttpResponseFactory responseFactory) { | |||
| return request.toRequest().flatMap(req -> fromCallable(() -> original.handle( | |||
| ctx, req, ctx.responseFactory())).map(HttpResponse::toStreamingResponse)); | |||
| ctx, req, ctx.responseFactory())).map(HttpResponse::toStreamingResponse).shareContextOnSubscribe()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RetryingHttpRequesterFilter uses the request across retry operations. The request's Publisher state is shared across retries and operators applied via transformMessageBody will therefore be reapplied on each retry. This typically isn't desirable from a semantics perspective but may also lead to StackOverflowException if enough retries are attempted.
Modifications: