Drain proxy CONNECT response before starting TLS handshake
#2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Successful response to `CONNECT` never has a message body, and we are not interested in payload body for any non-200 status code. Drain it asap to free connection and RS resources before starting TLS handshake. Modifications: - Drain response message body before invoking `handleConnectResponse`; - Use computed `ExecutionStrategy` to decide when `newConnection` should be offloaded, similar to what `AbstractLBHttpConnectionFactory` does; - Update `ProxyConnectConnectionFactoryFilterTest` to assert new behavior; Result: Response to `CONNECT` request is drained and all publishers are released before starting any new activity on this connection.
idelpivnitskiy
commented
Sep 13, 2023
| // payload body for any non-200 status code. Drain it asap to free connection and RS | ||
| // resources before starting TLS handshake. | ||
| .flatMap(response -> response.messageBody().ignoreElements() | ||
| .concat(Single.defer(() -> handleConnectResponse(c, response) |
There was a problem hiding this comment.
Tried to minimize git diff, added draining here instead of changing indentation inside handleConnectResponse
daschl
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
CONNECTnever has a message body, and we are not interested in payload body for any non-200 status code. Drain it asap to free connection and RS resources before starting TLS handshake.ConnectExecutionStrategy.Modifications:
handleConnectResponse;ExecutionStrategyto decide whennewConnectionshould be offloaded, similar to whatAbstractLBHttpConnectionFactorydoes;ProxyConnectConnectionFactoryFilterTestto assert new behavior;Result:
Response to
CONNECTrequest is drained and all publishers are released before starting any new activity on this connection.