ReplayStrategies.LazyTimeLimitedReplayAccumulator trims and accumulate #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The lazy accumulator doesn't eagerly evict items so it can be prone to poor behaviors under certain patterns. One of those patterns is having a large queue limit with a short timeout and infrequent re-subscribes. In this case a producer can fill the queue to the brim despite many elements being expired. Modifications: Trim stale entries when accumulating. Result: This removes a pathological case and leaves the only remaining pathological case being one where we get a large burst of messages, none of which have expired, and then we have no more new elements or subscribers for long durations which can put unnecessary pressure on the GC.
bryce-anderson
requested review from
Scottmitch,
mgodave,
tkountis,
daschl and
idelpivnitskiy
Scottmitch
approved these changes
Oct 5, 2023
Scottmitch
reviewed
Oct 5, 2023
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ReplayStrategies.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The lazy accumulator doesn't eagerly evict items so it can be prone to poor behaviors under certain patterns. One of those patterns is having a large queue limit with a short timeout and infrequent re-subscribes. In this case a producer can fill the queue to the brim despite many elements being expired.
Modifications:
Trim stale entries when accumulating.
Result:
This removes a pathological case and leaves the only remaining pathological case being one where we get a large burst of messages, none of which have expired, and then we have no more new elements or subscribers for long durations which can put unnecessary pressure on the GC.