Latency tracking utilities to support LB L7 breakers #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryce-anderson
approved these changes
Jan 8, 2024
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/DefaultLatencyTracker.java
Outdated
Show resolved
Hide resolved
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/DefaultLatencyTracker.java
Outdated
Show resolved
Hide resolved
| if (halfLifeNanos <= 0) { | ||
| throw new IllegalArgumentException("halfLifeNanos: " + halfLifeNanos + " (expected >0)"); | ||
| } | ||
| tau = halfLifeNanos / log(2); |
There was a problem hiding this comment.
ffti: probably not worth the noise but if you store inv_tau we can use multiplcation later on instead of the slower division.
There was a problem hiding this comment.
Is Math.pow((halfLifeNanos / log(2)), -1) what you had in mind?
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/DefaultLatencyTracker.java
Outdated
Show resolved
Hide resolved
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/DefaultLatencyTracker.java
Outdated
Show resolved
Hide resolved
servicetalk-loadbalancer/src/main/java/io/servicetalk/loadbalancer/LatencyTracker.java
Outdated
Show resolved
Hide resolved
…ncer/DefaultLatencyTracker.java Co-authored-by: Bryce Anderson <bryce_anderson@apple.com>
…ncer/LatencyTracker.java Co-authored-by: Bryce Anderson <bryce_anderson@apple.com>
bryce-anderson
approved these changes
Jan 8, 2024
bryce-anderson
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support latency tracking APIs and default EWMA based decay-able solutions to allow implementation of richer L7 circuit breakers for the load balancers.
Modification
Introduced the LatencyTracker API along with a default implementation.