Add HttpClients.forMultiAddressUrl() overload with ServiceDiscoverer
#2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschl
approved these changes
Feb 20, 2024
Motivation: Users who need multi-address client with `DiscoveryStrategy.ON_NEW_CONNECTION` and a custom `ServiceDiscoverer` implementation need a new overload, because this strategy does not allow changing `ServiceDiscoverer` later. Modifications: - Add `HttpClients.forMultiAddressUrl(String, ServiceDiscoverer, DiscoveryStrategy)` overload; - Add a test case in `HttpClientResolvesOnNewConnectionTest` that verifies the new overload can be used to customize `ServiceDiscoverer`; Result: Easier can customize `ServiceDiscoverer` when they need a multi-address client with `DiscoveryStrategy.ON_NEW_CONNECTION`.
idelpivnitskiy
force-pushed
the
forMultiAddress
branch
from
6567d10
to
23ce52a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Users who need multi-address client with
DiscoveryStrategy.ON_NEW_CONNECTIONand a customServiceDiscovererimplementation need a new overload, because this strategy does not allow
changing
ServiceDiscovererlater.Modifications:
HttpClients.forMultiAddressUrl(String, ServiceDiscoverer, DiscoveryStrategy)overload;HttpClientResolvesOnNewConnectionTestthatverifies the new overload can be used to customize
ServiceDiscoverer;Result:
Easier can customize
ServiceDiscovererwhen they need a multi-addressclient with
DiscoveryStrategy.ON_NEW_CONNECTION.