http-netty: Properly set the host header for MultiAddressUrlClient #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Users of the MultiAddressHttpClientBuilder are expected to put in a request target that includes the authority, which may or may not include the port. The authority should be directly reflected in the `Host` header but right now we will add both host and port regardless of what was specified. Modifications: Copy the authority information directly from the request when overrides haven't been specified.
…lize the authority
bryce-anderson
requested review from
tkountis,
daschl,
mgodave and
idelpivnitskiy
…ions with CONNECT requests
…on/HostHeaderMultiBuilder_opt2
...p-netty/src/main/java/io/servicetalk/http/netty/DefaultMultiAddressUrlHttpClientBuilder.java
Show resolved
Hide resolved
...cetalk-http-utils/src/main/java/io/servicetalk/http/utils/HostHeaderHttpRequesterFilter.java
Outdated
Show resolved
Hide resolved
daschl
approved these changes
Mar 13, 2024
...p-netty/src/main/java/io/servicetalk/http/netty/DefaultMultiAddressUrlHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Mar 13, 2024
bryce-anderson
deleted the
bl_anderson/bl_anderson/HostHeaderMultiBuilder_opt2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Users of the MultiAddressHttpClientBuilder are expected to put in a request target that includes the authority, which may or may not include the port. The authority should be directly reflected in the Host header but right now we will add both host and port regardless of what was specified. This is described in https://datatracker.ietf.org/doc/html/rfc7230#section-5.4.
Modifications:
Set the host header correctly right before we overwrite the requestTarget to relative form.
Note that this overrides the behavior of the
SingleClientAddressBuilder.hostHeaderFallback(..).See #2856 for an alternative that is more correct wrt user configured behavior but a lot more complex to follow.