Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadbalancer-experimental: add support for prioritization #2905

Merged
merged 12 commits into from
May 3, 2024

Conversation

bryce-anderson
Copy link
Contributor

Motivation:

We want a way to support grouping endpoints into prioritization
groups so we can favor some, but still fall back to another group
in the event things go wrong.

Modifications:

Add the notion of prioritization. This lets users define groups
which then get translated into adjusted weights and fed into
the standard endpoint selection algorithms.

@bryce-anderson bryce-anderson marked this pull request as ready for review May 1, 2024 17:31
@bryce-anderson bryce-anderson requested a review from daschl May 3, 2024 15:26
Copy link
Contributor

@tkountis tkountis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a few finals here & there, but nothing of importance to comment on, looks promising.
It would be nice to see how a sub-setting concept would look in this implementation. I have to process it a little more in my head, but i imagine the weight becomes very overloaded, and my fear is that reasoning will be harder.

@bryce-anderson
Copy link
Contributor Author

Missing a few finals here & there, but nothing of importance to comment on, looks promising. It would be nice to see how a sub-setting concept would look in this implementation. I have to process it a little more in my head, but i imagine the weight becomes very overloaded, and my fear is that reasoning will be harder.

You're right: using weight will make things more overloaded. Tbh, the overlay of subsetting and priority is probably going to be very tough regardless of how we represent them and are probably only compatible with some relatively stringent constraints.

@bryce-anderson bryce-anderson merged commit d02f866 into apple:main May 3, 2024
15 checks passed
@bryce-anderson bryce-anderson deleted the bl_anderson/priority-groups branch May 3, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants