Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package manifest API .branch deprecation #731

Merged
merged 1 commit into from Apr 20, 2023
Merged

Fix package manifest API .branch deprecation #731

merged 1 commit into from Apr 20, 2023

Conversation

MaxDesiatov
Copy link
Member

With Swift 5.7 we should use branch: name argument overload instead.

@MaxDesiatov
Fix package manifest API .branch deprecation
b706718 
With Swift 5.7 we should use `branch:` name argument overload instead.
@MaxDesiatov MaxDesiatov self-assigned this Apr 18, 2023
@MaxDesiatov
Copy link
Member Author

@swift-ci test

ahoppen
ahoppen approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank

@MaxDesiatov MaxDesiatov merged commit 1fc50ae into main Apr 20, 2023
3 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/package-branch branch April 20, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@benlangmuir benlangmuir Awaiting requested review from benlangmuir benlangmuir is a code owner

Assignees

@MaxDesiatov MaxDesiatov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaxDesiatov @ahoppen