Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of deprecated AbsolutePath and RelativePath initializers #738

Merged
merged 1 commit into from May 19, 2023
Merged

Fix use of deprecated AbsolutePath and RelativePath initializers #738

merged 1 commit into from May 19, 2023

Conversation

MaxDesiatov
Copy link
Member

Non-throwing overloads are deprecated, we should use throwing ones with validating: argument label.

@MaxDesiatov MaxDesiatov self-assigned this Apr 21, 2023
@MaxDesiatov
Copy link
Member Author

@swift-ci test

@MaxDesiatov
Copy link
Member Author

@ahoppen would you have a moment to take a look? Thanks!

ahoppen
ahoppen approved these changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxDesiatov MaxDesiatov merged commit 7dafe17 into main May 19, 2023
3 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/fix-nonthrowing-warnings branch May 19, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@fepimentel fepimentel fepimentel approved these changes

@benlangmuir benlangmuir Awaiting requested review from benlangmuir benlangmuir is a code owner

Assignees

@MaxDesiatov MaxDesiatov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MaxDesiatov @ahoppen @fepimentel