Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package.swift: fix deprecated dependency initializers #748

Merged
merged 3 commits into from May 24, 2023

Conversation

MaxDesiatov
Copy link
Member

@MaxDesiatov MaxDesiatov commented May 21, 2023

Package dependency initializer overload with a name: argument was deprecated in recent versions of SwiftPM. Let's replace it with a non-deprecated version to fix the dependency warning.

@MaxDesiatov MaxDesiatov self-assigned this May 21, 2023
@MaxDesiatov MaxDesiatov requested a review from ahoppen as a code owner May 21, 2023 20:26
@MaxDesiatov
Copy link
Member Author

@swift-ci test

2 similar comments
@MaxDesiatov
Copy link
Member Author

@swift-ci test

@MaxDesiatov
Copy link
Member Author

@swift-ci test

Copy link
Collaborator

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, as always, for fixing the warnings in SourceKit-LSP

@MaxDesiatov
Copy link
Member Author

@swift-ci test

@MaxDesiatov
Copy link
Member Author

@swift-ci test windows

…package-manager`

This checkout path is hardcoded in `update-checkout-config.json` of our `swift` repository and can't be easily changed, so we have to keep this deprecated initializer call for a bit more time.
@MaxDesiatov
Copy link
Member Author

@swift-ci test

@MaxDesiatov
Copy link
Member Author

@swift-ci test windows

@MaxDesiatov
Copy link
Member Author

@swift-ci test macos

@MaxDesiatov MaxDesiatov merged commit b7d4270 into main May 24, 2023
3 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/fix-manifest-deprecations branch May 24, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants