Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully decode InitializeRequest #756

Merged
merged 2 commits into from Jun 27, 2023
Merged

Fully decode InitializeRequest #756

merged 2 commits into from Jun 27, 2023

Conversation

JCWasmx86
Copy link
Contributor

@JCWasmx86 JCWasmx86 commented Jun 24, 2023 •
edited

I found out that clientInfo is not decoded. This fixes this issue and modifies a test to ensure deserialization works. It has no impact on sourcekit-lsp, but as I use your LSPBindings product I want to have access to clientInfo

@MaxDesiatov
Copy link
Member

@swift-ci test

@MaxDesiatov
Copy link
Member

@swift-ci test macos

@MaxDesiatov
Copy link
Member

@swift-ci test linux

ahoppen
ahoppen reviewed Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good catch. It looks like we have the same issue for the locale child. Could you add that to CodingKeys as well?

@JCWasmx86 JCWasmx86 changed the title Decode clientInfo Fully decode InitializeRequest Jun 26, 2023
ahoppen
ahoppen approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏🏽

@ahoppen
Copy link
Collaborator

ahoppen commented Jun 26, 2023

@swift-ci Please test

@ahoppen
Copy link
Collaborator

ahoppen commented Jun 27, 2023

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 869fd0a into apple:main Jun 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@benlangmuir benlangmuir Awaiting requested review from benlangmuir benlangmuir is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JCWasmx86 @MaxDesiatov @ahoppen