Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t update Package.resolved from sourcekit-lsp #762

Merged
merged 1 commit into from Jul 7, 2023
Merged

Don’t update Package.resolved from sourcekit-lsp #762

merged 1 commit into from Jul 7, 2023

Commits on Jul 7, 2023

  1. Don’t update Package.resolved from sourcekit-lsp 

    `SwiftPMWorkspace.reloadPackage` called `loadPackageGraph`, which causes package resolution and could thus update `Package.resolved`. This caused race conditions when `swift package update` was run from terminal while sourcekit-lsp is running since sourcekit-lsp was notified about the file changes and thus reloaded the pacakge to get build settings for the modified files.

Set `forceResolvedVersions` to only resolve packages based on the versions in `Package.resolved`, eliminating this problem.

Fixes apple#707
rdar://105173375
    @ahoppen
    ahoppen committed Jul 7, 2023
    Copy the full SHA
    1a26634 View commit details
    Browse the repository at this point in the history