Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Show a progress indicator in the editor if SourceKit-LSP is reloading packages" #771

Merged
merged 1 commit into from Jul 18, 2023

Conversation

bnbarham
Copy link
Contributor

Reverts #767

@bnbarham
Copy link
Contributor Author

Linux PR status started failing in the sourcekit-lsp integration tests between https://ci.swift.org/job/oss-swift-pr-test-ubuntu-20_04/4301/ and https://ci.swift.org/job/oss-swift-pr-test-ubuntu-20_04/4301/. This seems like the most likely commit, though honestly I've not looked into it more than seeing it touches actually source vs the other commits which are test fixes. The other change is ee269d3 but that should only impact the sourcekit-lsp tests, not the integration test.

@finagolfin
Copy link
Contributor

@ahoppen, it looks like this fixes the timeout that has broken the linux CI right now?

@ahoppen
Copy link
Collaborator

ahoppen commented Jul 18, 2023

@swift-ci Please test

@shahmishal shahmishal merged commit d261b0d into main Jul 18, 2023
0 of 3 checks passed
@hborla hborla deleted the revert-767-ahoppen/reloadpackage-progress branch July 18, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants