Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix executable path when calling custom completion in bash #323

Merged

Conversation

Frizlab
Copy link
Contributor

@Frizlab Frizlab commented Jun 3, 2021

In Bash, when calling completion for an executable written with full path (e.g. /opt/brew/bin/example), the completion script might call another executable if another executable with the same name happens to be first in the PATH. (This is particularly annoying when debugging completion in a project!) This PR fixes that.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@natecook1000
Copy link
Member

Looks solid @Frizlab — can you fix up the conflicts from your other fix?

@Frizlab Frizlab force-pushed the bash_custom_completion_fix_executable branch from eb74390 to 8f467e4 Compare June 4, 2021 18:09
@Frizlab
Copy link
Contributor Author

Frizlab commented Jun 4, 2021

@natecook1000 Done

@natecook1000
Copy link
Member

@swift-ci Please test

@Frizlab Frizlab force-pushed the bash_custom_completion_fix_executable branch from 8f467e4 to 450c59f Compare June 9, 2021 21:59
@Frizlab
Copy link
Contributor Author

Frizlab commented Jun 9, 2021

Fixed the test that was failing.

@natecook1000
Copy link
Member

@swift-ci Please test

@natecook1000 natecook1000 merged commit 37610bc into apple:main Jun 10, 2021
@Frizlab Frizlab deleted the bash_custom_completion_fix_executable branch June 10, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants