Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included help message when a required value is missing. #324

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Included help message when a required value is missing. #324

merged 1 commit into from
Jun 9, 2021

Conversation

dirtyhabits97
Copy link
Contributor

Hi, these changes should fix #314.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

natecook1000
natecook1000 reviewed Jun 8, 2021
View reviewed changes
Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @dirtyhabits97! Just a formatting tweak in the new help message, then this should be ready to merge.

Sources/ArgumentParser/Usage/UsageGenerator.swift Outdated Show resolved Hide resolved
@dirtyhabits97 dirtyhabits97 force-pushed the task/help_message_missing_value branch from 3f16029 to 86a75cb Compare June 8, 2021 16:50
@rauhul
Copy link
Contributor

rauhul commented Jun 9, 2021

@swift-ci Please test

@natecook1000 natecook1000 merged commit 530a754 into apple:main Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natecook1000 natecook1000 natecook1000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include help message when a required value is missing
3 participants
@dirtyhabits97 @rauhul @natecook1000