Add a primitive storage for managing critical state and platform abstracted locking #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-requisite for managing state for backing storage that cannot be managed as an actor (due to cancellation). Locking is heavily inspired from the cross platform implementation in swift-corelibs-foundation (but skipping the try lock and the recursive variant).
ManagedCriticalState is an abstraction around that locking primitive in addition controlling mutations to a stored value. This allows for transactions from multiple queues/actors/threads to shared state without requiring the memory layout of the stored value to fit into an atomic intrinsic.
With the state of
withTaskCancellationHandler
this becomes distinctly important for the cancel closure since that is NOT asynchronous and therefore cannot be meaningfully used with an actor. There is additional utility that this type could provide to non async/await code and perhaps should be considered for refinement into the standard library. (we seem to need this pattern a lot...)