Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark managed atomic constructs Sendable if their payloads are #46

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

lorentey
Copy link
Member

Resolves #45.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've verified that my change does not break any existing tests.
  • I've updated the documentation if necessary.

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey
Copy link
Member Author

17:36:08 
/Users/buildnode/jenkins/workspace/pr-swift-atomics-macos/branch-main/swift-atomics/Sources/Atomics/autogenerated/HighLevelTypes.swift:105:26: error: unknown attribute 'unchecked'
17:36:08 extension ManagedAtomic: @unchecked Sendable where Value: Sendable {}
17:36:08                          ^
17:36:08 /Users/buildnode/jenkins/workspace/pr-swift-atomics-macos/branch-main/swift-atomics/Sources/Atomics/autogenerated/HighLevelTypes.swift:82:14: error: non-final class 'ManagedAtomic' cannot conform to `Sendable`; use `UnsafeSendable`
17:36:08 public class ManagedAtomic<Value: AtomicValue> {
17:36:08              ^

ಠ_ಠ

@lorentey lorentey added this to the 1.0.2 milestone Sep 24, 2021
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey
Copy link
Member Author

@swift-ci test macOS platform

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey changed the title Mark atomic constructs Sendable if their payloads are Mark managed atomic constructs Sendable if their payloads are Sep 30, 2021
@lorentey
Copy link
Member Author

@swift-ci test

1 similar comment
@lorentey
Copy link
Member Author

lorentey commented Nov 9, 2021

@swift-ci test

@jpsim
Copy link
Contributor

jpsim commented Aug 9, 2022

It'd be great to land this so consumers don't need to @preconcurrency import Atomics.

@weissi
Copy link
Member

weissi commented Mar 16, 2023

It'd be great to land this so consumers don't need to @preconcurrency import Atomics.

+1

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey requested a review from glessard March 17, 2023 21:28
@lorentey lorentey merged commit a79166d into apple:main Mar 17, 2023
@lorentey lorentey deleted the sendable branch March 17, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The constructs provided by this package need to be marked Sendable
3 participants