Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum required toolchain to Swift 5.6 #67

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

lorentey
Copy link
Member

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've verified that my change does not break any existing tests.
  • I've updated the documentation if necessary.

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey requested a review from glessard March 17, 2023 21:15
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey added this to the 1.1.0 milestone Mar 17, 2023
@lorentey lorentey merged commit e6bb2b4 into apple:main Mar 17, 2023
@stevapple
Copy link

I believe this would break many downstream libraries including NIO (which still supports Swift 5.5). At least we shouldn’t make it though a minor update.

Is there anything we cannot work around?

@lorentey
Copy link
Member Author

This shouldn't affect downstream libraries -- SwiftPM is smart enough to limit updates to the most recent tag that supports the toolchain used: so NIO users on 5.5 will continue to get a 1.0 tag, while 5.6+ users will see 1.1 too.

My thinking in selecting 5.6 as the cutoff point is to emulate NIO's rule of supporting three public Swift releases -- with 5.8 nearing shipment, we'll have 5.6, 5.7 and 5.8 by the time this will get tagged. 🤞

@lorentey
Copy link
Member Author

(The package not remaining on obsolete language versions forever was a crucial consideration when we initially published the package, and it is explicitly called out in the README. If SPM didn't allow for doing this in minor releases, then we wouldn't have published this as a package in the first place. 😄)

@lorentey lorentey deleted the bump-toolchain-to-5.6 branch March 18, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants