Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the prose order in code voice #125

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

bytedriver
Copy link
Contributor

@bytedriver bytedriver commented Mar 28, 2023

This PR fixes a tiny text mistake in the sentence that you can find in the section Associated Values of the chapter "Enumerations"

If all of the associated values for an enumeration case are extracted as constants, or if all are extracted as variables, you can place a single var or let annotation before the case name, for brevity:

This PR swaps var and let annotation places in the sentence above.

Fixes #124

@amartini51 amartini51 changed the title Fix a tiny prose mistake in Associated Values. Match the prose order in code voice Mar 28, 2023
@amartini51
Copy link
Collaborator

amartini51 commented Mar 28, 2023

@bytedriver Thanks for making this correction! Do you mind if I reword the commit in terms of what was wrong and why it was changed? Here's my suggested commit message:

Match order in prose and code.

The first part of the sentence lists constants before variables, so put 'let'
before 'var' to match.

@bytedriver
Copy link
Contributor Author

@amartini51 Thank you for reviewing the changes.
I definitely agree with your suggestion about the commit message.
Please let me know if I have to reset the commit and push a new one with the new message.

The first part of the sentence lists constants before variables, so put
'let' before 'var' to match.
@amartini51
Copy link
Collaborator

Please let me know if I have to reset the commit and push a new one with the new message.

I made 0f6400a and force-pushed to your branch.

@bytedriver
Copy link
Contributor Author

@amartini51 Thanks a lot! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Tiny Prose Mistake in Associated Values in Enumerations
2 participants