Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the short syntax to unwrap optional properties #147

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

ofirmiron
Copy link
Contributor

@ofirmiron ofirmiron commented Jun 30, 2023

Because we're reusing the property names, we can use the shorter form as described in The Basics.

@amartini51 amartini51 self-requested a review June 30, 2023 20:57
@amartini51 amartini51 changed the title Implicitly unwrap optional properties Use the short syntax to unwrap optional properties Jun 30, 2023
@amartini51
Copy link
Collaborator

Edited the PR's title to avoid confusion with implicitly unwrapped optionals.

@amartini51
Copy link
Collaborator

amartini51 commented Jun 30, 2023

Thanks for the PR! This change looks good to me. I confirmed that this is the only code listing in the chapter that could switch over to the newer short syntax.

Do you mind editing the commit message? Or is it ok if I edit it for you? I'd like to remove the mention of "implicit" like I did in this PR's title, to avoid confusion with IUOs. For example:

Use the short syntax to unwrap optional properties.

Because we're reusing the property names, we can use the shorter form as
described in The Basics.

@ofirmiron
Copy link
Contributor Author

Thanks, done!

Because we're reusing the property names, we can use the shorter form as
described in The Basics.
@amartini51
Copy link
Collaborator

Thanks, done!

Not sure what happened, but your edited commit didn't show up. I still saw 8456acc

Since you're ok with the change, I amended the commit to edit its message, and force pushed it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants