Expand the concurrency chapter #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of thumbnails, it would be better to make separate tasks for each job so they can run in parallel and Swift can schedule them for you, which makes it a weaker example.
The discussion already doesn't promise that the work will happen in parallel, only that it can happen in parallel.
ktoso
approved these changes
Aug 4, 2023
etcwilde
reviewed
Aug 4, 2023
amartini51
commented
Aug 7, 2023
Co-authored-by: Evan Wilde <ewilde@apple.com> Co-authored-by: Konrad Malawski <konrad_malawski@apple.com>
Co-authored-by: Konrad Malawski <konrad_malawski@apple.com>
Incorporates feedback from Evan Wilde <ewilde@apple.com> and Konrad Malawski <konrad_malawski@apple.com>.
etcwilde
reviewed
Oct 3, 2023
The framing of "no suspension points means no other code runs" is at best misleading outside of an actor, because there can be other code running concurrently. Inside of an actor, this kind of no-await code is a useful best practice that we want to show.
amartini51
force-pushed
the
concurrency_75895184
branch
from
5a281f8
to
51e6d63
Compare
The previous paragraph talks about a single function that is both async and throwing -- but this paragraph describes some similarities between the two different kinds of functions, not about functions that are both.
Parallel and async code, by itself, doesn't give you memory safety. That's one of the reasons to use Swift concurrency -- to get memory safety in your code. Expand the "you can't do this" to give some follow-on advice about what you can do, in terms of adoption. Avoid the wording "even stronger" when there isn't an obvious guarantee being compared to.
chuckdude
requested changes
Nov 2, 2023
Edits from <rdar://117556772> Co-authored-by: Chuck Toporek <chuck_toporek@apple.com>
|
This has been looking quite good for a while, do we intend to merge soon @amartini51 or keep adding @amartini51 ? |
|
@ktoso I've got a few minor changes to make from Chuck's editorial review (likely this afternoon or tomorrow morning) then this will be ready to merge. |
Co-authored-by: Chuck Toporek <chuck_toporek@apple.com>
|
Looks good I think! Thanks Alex et al |
bjlanier
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: rdar://75895184