Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include trailing () in macro URLs. #160

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

amartini51
Copy link
Collaborator

@amartini51 amartini51 commented Jul 22, 2023

This change matches an upstream change in the publication pipeline that will start including the () at the end of macro's names. TSPL started linking to the macros that replace what used to be special literals in commit f2828dd, which is on 'main' but isn't yet included in the published content. So if the publication pipeline updates before this PR is merged, that's also ok — the links that would break aren't there yet.

Fixes: rdar://112501547

Copy link
Member

@krilnon krilnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, these changes match my expectation what's required for macro URLs going forward.

@amartini51 amartini51 merged commit e56627d into apple:main Jul 24, 2023
@amartini51 amartini51 deleted the macro_links_112501547 branch August 18, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants