Replace conformance macros with extension macros #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckdude
approved these changes
Nov 2, 2023
hborla
requested changes
Nov 7, 2023
Co-authored-by: Holly Borla <hborla@apple.com>
|
@hborla I've incorporated your corrections and filled in a couple more restrictions (from re-reading the SE proposal again) on where you can use extension macros and what they can do. Can you take another look at this PR now? |
bjlanier
approved these changes
Nov 9, 2023
hborla
approved these changes
Nov 30, 2023
Co-authored-by: Holly Borla <hborla@apple.com>
Co-authored-by: Holly Borla <hborla@apple.com>
Co-authored-by: Holly Borla <hborla@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because SE-0389 and SE-0402 both landed during the beta period for Swift 5.9, conformance macros were removed from the FCS version — so we don't discuss them in the documentation. I expect to mention this in a revision history entry like:
Fixes: rdar://116429287