Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visionOS extension to platform lists #227

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

amartini51
Copy link
Collaborator

Fixes: rdar://119329626

Confirmed this is supported as of swiftlang-5.9.2.2.56.
@amartini51
Copy link
Collaborator Author

Force pushed to update the commit message. The Swift 5.9.2 build number is more relevant than a 5.10 build number.

@Kyle-Ye
Copy link
Contributor

Kyle-Ye commented Jan 5, 2024

As I stated in #225, the open source Swift repo does not accept visionOS on 5.9.2. Is this an expected behavior?

@amartini51
Copy link
Collaborator Author

As I stated in #225, the open source Swift repo does not accept visionOS on 5.9.2. Is this an expected behavior?

I can't speak to whether it's expected compiler behavior that the OSS version of Swift doesn't recognize visionOS as a platform.

However, as stated in the Version Compatibility chapter, TSPL documents the version of Swift as it ships with Xcode. I would expect the differences between open-source versions and Xcode versions of Swift to be minor and temporary. If we see major differences or differences that remain long-term, we should have a larger discussion about how to handle that.

@Kyle-Ye
Copy link
Contributor

Kyle-Ye commented Jan 6, 2024

However, as stated in the Version Compatibility chapter, TSPL documents the version of Swift as it ships with Xcode.

Got it. Did not notice it before. I used to thought TSPL was aligned with apple/swift

@amartini51 amartini51 merged commit 95273ae into apple:main Jan 12, 2024
@amartini51 amartini51 deleted the vision_119329626 branch January 12, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants