Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

[CrashReproducer] Upstream a test for -index-store-path support. #318

Conversation

vsapsai
Copy link
Contributor

@vsapsai vsapsai commented May 14, 2019

Patch by Bruno Cardoso Lopes.

@vsapsai
Copy link
Contributor Author

vsapsai commented May 14, 2019

@swift-ci Please test

@bcardosolopes
Copy link
Contributor

When the tests pass (assuming failures are related), LGTM

@vsapsai
Copy link
Contributor Author

vsapsai commented May 15, 2019

Testing failure seems to be unrelated to the change

/Users/buildnode/jenkins/workspace/swift-clang-PR-osx/swift/stdlib/public/Darwin/Foundation/Data.swift:563:24: error: property does not override any property from its superclass

Will restart PR testing.

@vsapsai
Copy link
Contributor Author

vsapsai commented May 15, 2019

@swift-ci Please test

@vsapsai vsapsai force-pushed the upstream-index-store-path-crash-reproducer branch from 29c87b0 to 257a845 Compare August 15, 2019 00:25
@vsapsai
Copy link
Contributor Author

vsapsai commented Aug 15, 2019

Rebased on top of the latest upstream-with-swift, let's test again.

@swift-ci Please test

@vsapsai vsapsai force-pushed the upstream-index-store-path-crash-reproducer branch from 257a845 to f51ea58 Compare August 15, 2019 18:56
@vsapsai
Copy link
Contributor Author

vsapsai commented Aug 15, 2019

Rebased past the broken IndexingAction.cpp, works locally on macOS.

@swift-ci Please test

Copy link
Contributor

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsapsai vsapsai merged commit 1b668be into apple:upstream-with-swift Aug 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants