Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Windows Paths #33

Closed
2 tasks done
SDGGiesbrecht opened this issue May 3, 2021 · 1 comment · Fixed by #34
Closed
2 tasks done

Invalid Windows Paths #33

SDGGiesbrecht opened this issue May 3, 2021 · 1 comment · Fixed by #34
Labels
bug Something isn't working
Milestone

Comments

@SDGGiesbrecht
Copy link

Some files here and in swift‐collections‐benchmark contain paths that are invalid on Windows. As a result, SwiftPM cannot build swift‐collections from Windows. (It can cross‐compile to Windows just fine.)

[...]
Resolving https://github.com/apple/swift-collections at 0.0.2
[...]\.build\checkouts\swift-collections: error: Couldn’t check out revision ‘2d719d75a2065f213e58a5164384a3d2fcf9b59a’:
    error: invalid path 'Documentation/Announcement-benchmarks/Results/01 Deque: random access lookups.png'
[...]
Resolving https://github.com/apple/swift-collections-benchmark at 0.0.1
[...]\.build\checkouts\swift-collections-benchmark: error: Couldn’t check out revision ‘49297647d1c0855eb33ec18cd6ee1181727c159b’:
    error: invalid path 'Documentation/Assets/sample-results/01 Deque: random access lookups.png'
Error: Process completed with exit code 1.

Information

  • Package version: 0.0.2
  • Platform version: Windows 10
  • Swift version: Swift 5.4.0

Checklist

  • If possible, I've reproduced the issue using the main branch of this package.
  • I've searched for existing GitHub issues.

Steps to Reproduce

Simply attempt to check out each relevant repository on Windows. (An empty Windows GitHub action can be created to trigger a checkout attempt without a local Windows machine.)

@SDGGiesbrecht SDGGiesbrecht added the bug Something isn't working label May 3, 2021
@lorentey lorentey linked a pull request May 12, 2021 that will close this issue
7 tasks
@lorentey
Copy link
Member

#34 renamed these files in swift-collection, while apple/swift-collections-benchmark#9 resolved the same issue in swift-collections-benchmark. Thank you all!

Additionally, apple/swift-collections-benchmark#10 will prevent the benchmarking tool from trying to generate invalid filenames on Windows.

@lorentey lorentey added this to the 0.0.3 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants