Make Paths Windows‐Compatible

[SDGGiesbrecht]

This resolves swift‐collections‐benchmark’s portion of apple/swift-collections#33.

Checklist

• I've read the Contribution Guidelines
• My contributions are licensed under the Swift license.
• I've followed the coding style of the rest of the project.
• I've added tests covering my changes (if appropriate).
  • I have included a Windows GitHub action that will catch regressions, but I can remove it again if you would prefer.
• I've verified that my change compiles and works correctly, and does not break any existing tests.
  • I searched for the filenames across the project and hopefully found and changed everything that pointed at them.
  • I do not know whether these identifiers refer to the images or not, or if they are user‐facing. It also is not clear to me whether they are reused in generating documentation, or if they are just an archived example. Let me know what you want done with them.
• [N/A] I've updated the documentation (if appropriate).

[lorentey]

These file names were generated by the tool itself, based on the corresponding library definition, which has been updated to use - instead of :, and we should use the same names here.

To prevent similar issues when people try to run benchmarks on Windows, it would be a good idea to make sure the tool filters out invalid characters from the filenames it generates. The filename sanitizer code is currently really dumb, and it's not even factored out. I like the idea of systematically replacing /, \\, :, >, \0 etc with underscores, depending on the current system.

(It needs to be possible to use colons and angle brackets in chart titles, even if the underlying filesystem forbids their use.)

[SDGGiesbrecht]

These file names were generated by the tool itself, based on the corresponding library definition, which has been updated to use - instead of :, and we should use the same names here.

L.O.L. I was trying to work on the dependency graph from the bottom up (swift-collections-benchmarks before swift-collections), but I guess I was holding it backwards. With the original definitions changed, will all the derived stuff in this repository be automatically fixed by the next run? If so, then I recommend just doing that and scrapping this PR. This was done by hand not realizing root definitions existed elsewhere.

[lorentey]

Oh, these won't be automatically regenerated -- synchronizing the filenames will just make things easier if these examples ever need to be recreated.

[SDGGiesbrecht]

I addressed the feedback about existing changes.

To prevent similar issues when people try to run benchmarks on Windows, it would be a good idea to make sure the tool filters out invalid characters from the filenames it generates.

I would rather leave that for someone more familiar with the Windows than I am. It does not appear that simple: https://stackoverflow.com/a/1976050/5280938

[lorentey]

Looks good! Thank you 😊

[lorentey]

@swift-ci test

[lorentey]

I submitted #10 to fix generated filenames on Windows.