Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privacy Manifest #363

Closed
aiKrice opened this issue Feb 19, 2024 · 7 comments
Closed

Add Privacy Manifest #363

aiKrice opened this issue Feb 19, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@aiKrice
Copy link

aiKrice commented Feb 19, 2024

According to https://developer.apple.com/support/third-party-SDK-requirements/
We need to have a Privacy manifest in this Lib (pretty strange to ask this from an Apple Repo :D )

@aiKrice aiKrice added the enhancement New feature or request label Feb 19, 2024
@xwu
Copy link
Contributor

xwu commented Feb 19, 2024

This isn't a third-party SDK.

@lorentey
Copy link
Member

Indeed, this package is not third-party SDK, and it isn't subject to these requirements.

(To be very clear, this package does not collect any information whatsoever, neither from end users nor developers. Nor does it use any required reason APIs.)

@lorentey
Copy link
Member

(If you get feedback otherwise, let us know and we'll look into it!)

@rockbruno
Copy link

It certainly is, you can see from the list that they require manifests even for simple utilities like OrderedSet. So even though they used the term "third-party SDK", they clearly mean any type of code here. But if swift-collections doesn't use required reason APIs then it indeed doesn't need to do anything.

@lorentey
Copy link
Member

The name OrderedSet in that list refers to a third-party code base ("SDK") of that name.

It does not refer to the type OrderedSet in this package. This package is called "Swift Collections", or "swift-collections", and if it was a third-party SDK (which it most certainly isn't), then it would be listed under that name.

Again, please reach out to me if you get official App Store feedback that indicates otherwise.

@vanvoorden
Copy link
Contributor

@lorentey Hmm… given the potential for confusion and ambiguity here on the part of developers… could we arrange to have that Apple Developer Support page updated with an explicit "allowlist" to make it clear that some Apple GitHub repos are safe to include without a privacy manifest? There's some signal here IMO that it would be helpful to document that and help make things more clear for developers.

@rockbruno
Copy link

@lorentey Yes, I am aware OrderedSet is a different package and that swift-collections doesn't need a manifest as of writing. I was just pointing that many of the "SDKs" in Apple's list are packages just like this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants