-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMake] Match lowercase "aarch64" #111
Conversation
Gah, GitHub cannot do rebases. @neonichu can you please rebase this on top on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
How are we supposed to test this case?
Seems like it is also possible for "aarch64" to be spelled lowercase, this fixes building on Ubuntu on arm at least.
ac5152d
to
39a16a1
Compare
Rebased on In terms of testing, @shahmishal should be able to answer this. I am assuming we have some way of doing CI on aarch64, but not sure what it is. |
@swift-ci test |
We should be able to cross pull request test this by creating a fake PR on Swift repo. |
IIUC, toolchain builds will only test tagged releases, by design. But that's still much better than nothing! 👍 |
Looks like the toolchain build succeeded and I also tested locally in an aarch64 Docker container. |
@lorentey lmk when we have a tag and I will pull this in |
@tomerd Oh, I'll make a new tag right now! |
1.0.1 is out now -- https://github.com/apple/swift-collections/releases/tag/1.0.1 |
Seems like it is also possible for "aarch64" to be spelled lowercase, this fixes building on Ubuntu on arm at least.