Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0][benchmark] Update std::function syntax for current C++ #314

Merged
merged 1 commit into from Oct 3, 2023

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Oct 3, 2023

C++17 has removed std::unary_function. Migrate to using std::function.

(This may break our ability to build benchmarks with older clang/libc++ releases. That is fine.)

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@lorentey
Copy link
Member Author

lorentey commented Oct 3, 2023

@swift-ci test

@lorentey lorentey added this to the 1.0.5 milestone Oct 3, 2023
@lorentey lorentey mentioned this pull request Oct 3, 2023
@lorentey lorentey merged commit a902f18 into apple:release/1.0 Oct 3, 2023
1 of 2 checks passed
@lorentey lorentey deleted the fix-c++-benchmarks branch October 3, 2023 04:27
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Oct 3, 2023
…v1.0.5 (#636)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[com_github_apple_swift_collections](https://togithub.com/apple/swift-collections)
| http_archive | patch | `1.0.4` -> `1.0.5` |

---

### Release Notes

<details>
<summary>apple/swift-collections
(com_github_apple_swift_collections)</summary>

###
[`v1.0.5`](https://togithub.com/apple/swift-collections/releases/tag/1.0.5):
Swift Collections 1.0.5

[Compare
Source](https://togithub.com/apple/swift-collections/compare/1.0.4...1.0.5)

This bugfix release improves compatibility with recent Swift versions,
eliminating several compiler warnings on Swift 5.8 and 5.9. It contains
no API-level changes.

##### What's Changed

- build: add ARM64 to the architecture mappings for Windows by
[@&#8203;compnerd](https://togithub.com/compnerd) in
[apple/swift-collections#265
- Fix deprecated UnsafeMutablePointer.assign(repeating:count) method by
[@&#8203;FelixHerrmann](https://togithub.com/FelixHerrmann) in
[apple/swift-collections#268
- \[1.0]\[test] Fix typename shadowing warning in Swift 5.9 by
[@&#8203;lorentey](https://togithub.com/lorentey) in
[apple/swift-collections#315
- \[1.0]\[benchmark] Update std::function syntax for current C++ by
[@&#8203;lorentey](https://togithub.com/lorentey) in
[apple/swift-collections#314

##### New Contributors

- [@&#8203;FelixHerrmann](https://togithub.com/FelixHerrmann) made their
first contribution in
[apple/swift-collections#268

**Full Changelog**:
apple/swift-collections@1.0.4...1.0.5

Thank you to everyone who contributed to this release!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant