Foundation: Windows long file support in FileManager.createDirectory (

#4771) Adjust the `createDirectory` path on Windows to properly support long file paths. This helps improve the DocC test coverage on Windows.
apple · Jun 19, 2023 · ba1e4f6 · ba1e4f6
1 parent 97a604c
commit ba1e4f6
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/Sources/Foundation/FileManager+Win32.swift b/Sources/Foundation/FileManager+Win32.swift
@@ -269,20 +269,20 @@ extension FileManager {
             }
         }
 
-        try FileManager.default._fileSystemRepresentation(withPath: path) { fsr in
-          var saAttributes: SECURITY_ATTRIBUTES =
-            SECURITY_ATTRIBUTES(nLength: DWORD(MemoryLayout<SECURITY_ATTRIBUTES>.size),
-                                lpSecurityDescriptor: nil,
-                                bInheritHandle: false)
-          try withUnsafeMutablePointer(to: &saAttributes) {
-            if !CreateDirectoryW(fsr, $0) {
-              throw _NSErrorWithWindowsError(GetLastError(), reading: false, paths: [path])
+        try withNTPathRepresentation(of: path) { wszPath in
+            var saAttributes: SECURITY_ATTRIBUTES =
+                SECURITY_ATTRIBUTES(nLength: DWORD(MemoryLayout<SECURITY_ATTRIBUTES>.size),
+                                    lpSecurityDescriptor: nil,
+                                    bInheritHandle: false)
+            try withUnsafeMutablePointer(to: &saAttributes) { pSecurityAttributes in
+                guard CreateDirectoryW(wszPath, pSecurityAttributes) else {
+                    throw _NSErrorWithWindowsError(GetLastError(), reading: false, paths: [path])
+                }
             }
-          }
+        }
 
-          if let attr = attributes {
-            try self.setAttributes(attr, ofItemAtPath: path)
-          }
+        if let attributes {
+            try self.setAttributes(attributes, ofItemAtPath: path)
         }
     }