Disable file/dispatch-related code in Foundation for WASI #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
78 tasks
MaxDesiatov
force-pushed
the
maxd/wasi-foundation
branch
from
13e0140
to
bbb1676
Compare
|
@swift-ci please test |
|
Same comments here re: NSCoding. |
MaxDesiatov
force-pushed
the
maxd/wasi-foundation
branch
4 times, most recently
from
c7ae122
to
7a98383
Compare
|
@swift-ci please test |
|
@millenomi I've re-enabled |
MaxDesiatov
force-pushed
the
maxd/wasi-foundation
branch
from
7a98383
to
4464ada
Compare
|
@swift-ci please test |
MaxDesiatov
force-pushed
the
maxd/wasi-foundation
branch
4 times, most recently
from
c54b739
to
ed90316
Compare
MaxDesiatov
force-pushed
the
maxd/wasi-foundation
branch
from
ed90316
to
4acfd49
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@MaxDesiatov I'm looking tomorrow. |
|
@millenomi any updates? |
|
Things slipped a little but I'm finally looking right now >.<' |
|
I'm going to take it for right now, but I hope we can have follow-ups to re-expose |
|
That makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality related to Dispatch, run loops, and full filesystem access (other than stdio/stderr file handles) is not available on WASI/Wasm. As a follow-up to previous Core Foundation PRs, this one updates parts of Foundation to add support for that platform.