-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize factory patterns for use outside of NSValue #1095
Closed
Closed
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
165b89a
Generalize factory patterns for use outside of NSValue
phausler 8dc8ad8
Remove the CF base from NSNumber
phausler 2077ee2
refine the documentation on _NSFactory
phausler 417c95c
Remove the _CFNumberInit family since it is no longer used
phausler f5a686f
Extract NSCFNumber into its own type and seperate bridges into their …
phausler 6b3324d
add a placeholder for NSString to String initialization
phausler bc5e153
Refactor NSTimeZone to use factory patterns
phausler 33c2dc3
Re-work bridging for InputStream/OutputStream to use factory patterns
phausler 4996aa0
Rework NSCharacterSet to use factory patterns and re-import Character…
phausler 1489cff
add bridge callouts for CFCharacterSet and CFStream
phausler 81066e1
Convert NSString to factory patterns and corect a few outstanding bug…
phausler e95183d
Update NSData to use factory patterns and update bridging patterns to…
phausler 1d9ddb7
Conditionalize _ObjectiveCBridgeable to non DEPLOYMENT_RUNTIME_SWIFT …
phausler 78c5784
Correct copyright notices to swift.org attribution
phausler 96b3fbc
Avoid as cast in CharacterSet
phausler 6fbdc1c
Avoid a warning for nullability of array elements
phausler 873f171
memset and memmove are nonnull on linux
phausler 6235e2a
restore hasPrefix and hasSuffix (and add substring calls for it)
phausler c78d3a1
Correct NSCopyMemoryPages memmove optionality
phausler 96d32ed
Correct linux code path for free in NSDeallocateMemoryPages
phausler 240dd54
Additional linux compatability shims for CF enum types and some addit…
phausler a0f964a
Remove unimplemented AutoreleasingUnsafeMutablePointer using function…
phausler e646150
Update constants and bit fields for linux/darwin compatability
phausler c64924e
Additional fixes for linux targets
phausler 560d826
Migrate for numeric truncation
phausler 31742c1
Recover from some merge damage in TestNSCharacterSet
phausler f5efffd
Add back in Codable support for CharacterSet
phausler ea11e17
use unsafeBitCast instead of _unsafeReferenceCast (which does not wor…
phausler c51f3d0
Convert to bit cast from extracted NS from NSCharacterSet.copy() to C…
phausler 18713a7
Copy UTF32BE and UTF32LE data files to test resources
phausler 8b18ee1
restore the 32BE/LE BOM test for path initialization
phausler File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the HALT uncommented here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using it to catch some failures in bridge casts