SR-5596: TimeZone.current returns wrong value #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The length passed to CFStringCreateWithBytes() included an extra random byte after the NUL. This meant the string was sometimes interpreted as non-ASCII (if the byte was >= 0x80) and the timezone would come back as NULL thus defaulting to GMT.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
|
Let's get this on the 4.0 branch too. |
|
Looks like this got merged to the 4.0 branch before the auto merge was switched off |
|
Great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
random byte after the NUL. This meant the string was sometimes
interpreted as non-ASCII (if the byte was >= 0x80) and the
timezone would come back as NULL thus defaulting to GMT.
This was broken in #1126 which dealt with the macOS timezone directory