Android: Fixed prepare.sh to download the toolchain instead from http… #1207
Conversation
…://johnholdsworth.com/android_toolchain.tgz as the old link is not working anymore.
|
Hi @jckarter please check this one, thanks. |
|
Hi @amraboelela, all these files can be deleted now thanks. I have an open PR to do just that :) |
|
@johnno1962 which PR is that? |
|
I don't understand, how the changes in #1113 will prevent the need for all the files in android directory? |
|
They are a long way out of date and intended for people who are porting to android themselves. It’s not really the place for such documentation. |
|
@johnno1962 how can I build Foundation for Android using your changes in #1113 ? I can test it and let you know. |
|
Thanks. I had hoped to be able to support people building their own foundation using the toolchain as all the headers and libs are there but it is missing clang. The easiest way to replicate the process is follow the swift-robot-environment scripts https://github.com/SwiftJava/swifty-robot-environment. You shouldn’t need to test it though as all those changes are already in the toolchain of last weekend. |
|
I prefer to keep the manual script, as the robot script runs too many subscripts like cloning, which I already did. The manual scripts, everyone can customize them later anyway they like. |
|
Hi @milseman could you find the right people to check this PR? Thanks :) |
|
@johnno1962 is probably the best for this change. CC-ing @parkera as it's in Foundation. |
|
@milseman is @johnno1962 the one you mentioned to me to contact, when I met you in WWDC17 ? |
|
Sorry, I don't remember. @modocache also has some experience in Swift for Android. |
|
HI @amraboelela, I’ll have a new toolchain for you tomorrow which allows people to rebuild foundation independently on macOS. There is no point in trying to fix these scripts. They are miles out of date. |
|
@johnno1962 I am trying to use the scripts in your robot repo to fix the existing scripts, so this should be feasible. Also the robot scripts are tied to your own swift fork, and tied to older revisions to the other swift repositories. We need to have scripts inside apple repositories which does the build and be up to date. |
|
Hi @amraboelela, I’ve uploaded a new version of the toolchain >here< containing the script `"swift-install/rebuild_foundation.sh” which should do what you are trying to do without any external dependencies. It’s very difficult setting up a build environment otherwise. I’d still rather these scripts were deleted as they are of low quality (I should know - I wrote them!) and not relevant to foundation for most people. If you want to fix these scripts rebuild_foundation.sh would be your starting point. |
|
I don't mind deleting them if we have an alternative script which is accessable from within the apple foundation repository. Thanks. |
|
I think it's unrealistic to expect "We need to have scripts inside apple repositories which does the build and be up to date.” at this time. The process, though documented at the swifty-robot-environment repo (for anybody who wants to replicate it) is too informal to ever make it into an Apple repo and Android is not a supported platform anyway. I can’t think of anything useful that could be left in the place of these scripts other than a README.md referring people to this repo and the pre-built toolchain for now. |
|
Hi @johnno1962 I already created swift/utils/android/build-toolchain script and would like to continue improving it. Everybody welcomed that script which means they have no objection having such scripts inside Apple repo. You did a good job in the robot scripts, so let me work into improving the build-toolchain script that I started. @milseman do you have input on this? |
|
I think @johnno1962's points are compelling, though there will always be some Android build configuration left in the Swift's build system (e.g. CMake support). I have no horses in this race otherwise. @parkera, what do you think? |
|
Let's close this PR for now. |
Android: Fixed prepare.sh to download the toolchain instead from http://johnholdsworth.com/android_toolchain.tgz as the old link is not working anymore.