SR-5871: TestThread.test_threadStart failing sporadically on Ubuntu 14.04 #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4.04 - Lock the NSCondition variable before creating the thread, otherwise the thread could broadcast on the condition variable before the parent has waited on it.
|
@swift-ci please test |
|
@ianpartridge I reread the man page for condition variables so I think these are being used in the correct order now. Worth a merge to see if it fixes the issue? |
alblue
reviewed
Sep 18, 2017
| @@ -41,14 +41,15 @@ class TestThread : XCTestCase { | |||
|
|
|||
| func test_threadStart() { | |||
| let condition = NSCondition() | |||
| condition.lock() | |||
There was a problem hiding this comment.
Doesn't this end up locking on the condition twice? Is that supported?
There was a problem hiding this comment.
The first lock happens in the parent thread - it acquires the lock.
The second lock happens in the newly created lock - it blocks waiting to acquire it.
When the parent thread calls condition.wait() the lock is unlocked and then the 2nd thread acquires it.
There was a problem hiding this comment.
Ah, yes - the change makes sense in that regard.
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise the thread could broadcast on the condition variable
before the parent has waited on it.