Require gold on linux and freebsd by default. #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci please test |
|
@swift-ci test |
millenomi
approved these changes
Apr 25, 2018
|
@swift-ci please test and merge |
|
13:56:18 /home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/Ninja-ReleaseAssert/swiftpm-linux-x86_64/x86_64-unknown-linux/release/swift-test: error while loading shared libraries: libswiftSwiftOnoneSupport.so: cannot open shared object file: No such file or directory |
|
@swift-ci test |
|
@shahmishal Do you know whats going on with this? We are failing in swiftpm due to Ononesupport not being there. |
- If building in debug mode, add an RPATH to the build lib dir of swift so that libFoundation.so can find libswiftSwiftOnone.so, required when using -Onone. (cherry picked from commit 2ba2086)
This commit just changes the default to require gold. The user can still override from the command line if they choose to. The reason why I am making this change is to match Swift's behavior here. There really isn't any good reason to have separate linkers compiling separate parts of the same build. rdar://39456714
gottesmm
force-pushed
the
swift-4.1-branch_rdar39456714
branch
from
b765713
to
e6e35e1
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit just changes the default to require gold. The user can still override from the command line if they choose to.
The reason why I am making this change is to match Swift's behavior here. There
really isn't any good reason to have separate linkers compiling separate parts
of the same build.
rdar://39456714