SR-8560: XMLDocument on Linux crashes with a Segmentation Fault #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When returning an XMLNode, take a reference to the parent XMLDocument to prevent the underlying libxml xml document from being freed. - This prevents the document being freed if a reference is still held to a XMLNode but not the XMLDocument.
|
@swift-ci please test |
parkera
approved these changes
Aug 21, 2018
|
Looks good to me. |
|
@swift-ci please test and merge |
michelf
reviewed
Aug 25, 2018
| @@ -790,6 +793,11 @@ open class XMLNode: NSObject, NSCopying { | |||
| withUnretainedReference { | |||
| _CFXMLNodeSetPrivateData(_xmlNode, $0) | |||
| } | |||
| if let documentPtr = _CFXMLNodeGetDocument(_xmlNode) { | |||
| if documentPtr != ptr { | |||
| _xmlDocument = XMLDocument._objectNodeForNode(documentPtr) | |||
There was a problem hiding this comment.
Won't this create a cyclic strong reference? The document has a reference to its children, and children have a reference to the document. The objects will never be deallocated unless you detach all the children to break the cycle.
This was referenced Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When returning an XMLNode, take a reference to the parent
XMLDocument to prevent the underlying libxml xml document
from being freed.
This prevents the document being freed if a reference is still
held to a XMLNode but not the XMLDocument.