Remove two-digit year cookie format support & unit test (fails on Ubu… #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@swift-ci Please test |
|
Unfortunately I don't think we have any way to test 14.04 from CI right now. @shahmishal? |
|
Correct, we don't currently support PR testing on 14.04. |
|
I'm going to merge this ahead of Foundation reviewers to get the bots back, but there's probably a way to write this test so that it can dynamically check for a new enough ICU. That's outside my area, though, so for now let's take this. |
maksimorlovich
added a commit
to maksimorlovich/swift-corelibs-foundation
that referenced
this pull request
Sep 27, 2018
Merged
parkera
pushed a commit
that referenced
this pull request
Oct 1, 2018
* Various Cookie fixes - Add support for additional Set-Cookie formats that web servers can return - Properly handle HTTP header parsing to extract values since values can contain colons - Make sure to set cookies on redirect requests - Use setValue instead of addValue when applying cookies to requests otherwise, Cookie header might contain: cookie1=value1,cookie1=value1; cookie2=value2 - New unit tests for cookie formats and redirect with Set-Cookie (cherry picked from commit 97a93b5) * Remove two-digit year cookie format support & unit test (fails on Ubuntu 14.04) (#1707)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntu 14.04)