Update CMake build to pass -I ICU_INCLUDE_DIR #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This allows building with a non system libicu.
|
@swift-ci test |
compnerd
requested changes
Nov 2, 2018
|
@swift-ci test |
|
@swift-ci test |
compnerd
reviewed
Nov 2, 2018
| @@ -0,0 +1 @@ | |||
| ../../../cmake/modules/FindICU.cmake | |||
There was a problem hiding this comment.
Ugh, the symlink is painful since it will break checkouts on Windows. Can you please copy?
compnerd
approved these changes
Nov 2, 2018
|
apple/swift#19860 has been merged |
|
@swift-ci clean test |
|
@swift-ci test |
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows building with a non system libicu.
Required to build SR-8876: Always build libicu on Linux swift#19860