Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable ICU tests now that Linux always builds with a newer version #1748

Merged
merged 2 commits into from Nov 29, 2018
Merged

Re-enable ICU tests now that Linux always builds with a newer version #1748

merged 2 commits into from Nov 29, 2018

Conversation

spevans
Copy link
Collaborator

@spevans spevans commented Nov 3, 2018 •
edited

Resolves SR-250, SR-7589

@spevans
Copy link
Collaborator Author

spevans commented Nov 3, 2018

@swift-ci test

@spevans spevans self-assigned this Nov 3, 2018
@spevans
Copy link
Collaborator Author

spevans commented Nov 3, 2018

Will hold off merging until manual tests on Ubuntu14 have been run

@spevans
Copy link
Collaborator Author

spevans commented Nov 3, 2018

@compnerd Is there a way of passing the --verbose option to ctest so that the full output from TestFoundation shows up in the logs?

@compnerd
Copy link
Collaborator

compnerd commented Nov 3, 2018

@spevans - Sorry, I never even thought about doing that since I would just run the target locally and look at the logs. It would require tweaking build-script-impl to enable this (and you are right, we should). Really all it boils down to is passing CTEST_OUTPUT_ON_FAILURE=TRUE to the test command (e.g. ninja -C ... test CTEST_OUTPUT_ON_FAILURE=TRUE).

@spevans spevans mentioned this pull request Nov 3, 2018
Closed
@spevans
Copy link
Collaborator Author

spevans commented Nov 3, 2018

@swift-ci test

1 similar comment
@spevans
Copy link
Collaborator Author

spevans commented Nov 4, 2018

@swift-ci test

@spevans spevans mentioned this pull request Nov 4, 2018
Merged
@spevans spevans changed the title Re-enable ICU tests now that Linux always builds with a newer version [DNM] Re-enable ICU tests now that Linux always builds with a newer version Nov 4, 2018
@spevans
Copy link
Collaborator Author

spevans commented Nov 4, 2018

Please test with the following request:
apple/swift#20314

@swift-ci test

@spevans
Copy link
Collaborator Author

spevans commented Nov 5, 2018

@swift-ci test

@spevans
SR-250: Disabled currency number formatter tests on Linux due to ICU …
d2a058b 
…dependency

- ICU is now built as part of the Ubuntu Linux built which fixes
  these tests.
@spevans
SR-7589: Test Case 'TestNumberFormatter.test_currencyPluralMinimumInt…
0eeb5a0 
…egerDigits' crashed on Ubuntu 14.04

- Newer verison of ICU used now fixes these issues.
@spevans
Copy link
Collaborator Author

spevans commented Nov 7, 2018

@swift-ci test

1 similar comment
@spevans
Copy link
Collaborator Author

spevans commented Nov 7, 2018

@swift-ci test

@spevans spevans changed the title [DNM] Re-enable ICU tests now that Linux always builds with a newer version Re-enable ICU tests now that Linux always builds with a newer version Nov 7, 2018
@spevans
Copy link
Collaborator Author

spevans commented Nov 7, 2018

Manually tested ok on Ubuntu14.04

@spevans spevans requested a review from parkera November 7, 2018 20:13
@millenomi
Copy link
Contributor

@swift-ci please test

@spevans
Copy link
Collaborator Author

spevans commented Nov 9, 2018

@swift-ci test linux

@spevans
Copy link
Collaborator Author

spevans commented Nov 10, 2018

@swift-ci test osx

2 similar comments
@spevans
Copy link
Collaborator Author

spevans commented Nov 10, 2018

@swift-ci test osx

@spevans
Copy link
Collaborator Author

spevans commented Nov 12, 2018

@swift-ci test osx

@spevans
Copy link
Collaborator Author

spevans commented Nov 13, 2018

@swift-ci test

@spevans
Copy link
Collaborator Author

spevans commented Nov 29, 2018

@swift-ci test and merge

@swift-ci swift-ci merged commit 248fc2e into apple:master Nov 29, 2018
This was referenced Nov 14, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkera parkera Awaiting requested review from parkera

Assignees

@spevans spevans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spevans @compnerd @millenomi @swift-ci