SR-9322: DateFormatter difference between macOS and Linux #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When parsing a date, return nil if the date to be parsed was not fully consumed by the parse format.
|
@swift-ci test |
parkera
approved these changes
Feb 11, 2019
|
@swift-ci test and merge |
lxbndr
added a commit
to readdle/swift-corelibs-foundation
that referenced
this pull request
May 6, 2020
Apple implementation checks for unparsed content in source string. Any non-whitespace leftover characters are considered as failure. On the other hand, whitespaces are permitted and should not affect the result. The check was partially implemented in apple#1822 (SR-9322). This patch alters verification logic to be closer to Apple implementation.
lxbndr
added a commit
to readdle/swift-corelibs-foundation
that referenced
this pull request
May 11, 2020
Apple implementation checks for unparsed content in source string. Any non-whitespace leftover characters are considered as failure. On the other hand, whitespaces are permitted and should not affect the result. The check was partially implemented in apple#1822 (SR-9322). This patch alters verification logic to be closer to Apple implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fully consumed by the parse format.