[4.2] NSDecimalNumber: Add missing init(value:) initialisers. #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test 4.2 |
spevans
changed the title
weissi
requested changes
Feb 11, 2019
|
If I recall correctly I think these initialisers were missing originally but I can always remove them if necessary. The |
|
@spevans yes, I think we should try to not add API (in this case the inits) unless strictly necessary. This might break code (because it might cause ambiguity). |
- Set the mantissa correctly. (cherry picked from commit 641e2cb)
spevans
force-pushed
the
pr_nsdecimalnumber_init_42
branch
from
9efe369
to
86c4684
Compare
|
@swift-ci test 4.2 |
1 similar comment
|
@swift-ci test 4.2 |
|
@parkera - is there an ability to run a source compatibility test like on swift with Foundation? |
|
@weissi I removed the other |
weissi
approved these changes
Feb 12, 2019
|
@compnerd not sure about the source compatibility test; @shahmishal do you know if we can trigger that from here? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correctly.
(cherry picked from commit 641e2cb)