Avoid FP arithmetic if unnecessary in CGRect.intersection(_:) #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a unit test to this covering the example from the jira? |
|
@spevans Updated! |
Jumhyn
commented
Mar 8, 2019
| width = overlapH.upperBound - overlapH.lowerBound | ||
| } | ||
|
|
||
| let height: CGFloat |
There was a problem hiding this comment.
Would this be better as a multi-ternary?
let height = overlapV == rect1SpanV ? rect1.height :
overlapV == rect2SpanV ? rect2.height :
overlapV.upperBound - overlapV.lowerBound
|
@swift-ci test |
|
@spevans Does the error here appear to be related to these changes? It's fairly opaque to me. |
|
@swift-ci please test |
|
@compnerd Any idea what this failure is? I've just rebased against |
|
Unfortunately, that erases the logs, so you cannot really tell what went wrong. |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See SR-10056 for a summary of this issue with example. The floating point arithmetic in
CGRect.intersection(_:)results in a rectangle not equal to its intersection withCGRect.infinity.