Fixing grammar issue #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkera
pushed a commit
that referenced
this pull request
Aug 19, 2016
* [SR-2151]NSJSONSerialization.data produces illegal JSON code NSJSONSerialization.data(withJSONObject:options) produces illegal JSON code https://bugs.swift.org/browse/SR-2151 * decoupling formatting logic and lazy loading formatter 1. moved format logic out of NSNumber and in to NSJSonSerialization 2. lazy load the formatter to be instantiated if needed 3. create a single format string to work with all formats since we are lazy loading a single formatter * fix build break update to latest master by removing casting and updating syntax
millenomi
pushed a commit
that referenced
this pull request
Nov 11, 2020
Witness table accessors return a witness table for a given type's conformance to a protocol. They are called directly from IRGen (when we need the witness table instance) and from runtime conformance checking (swift_conformsToProtocol digs the access function out of the protocol conformance record). They have two interesting functions: 1) For witness tables requiring instantiation, they call swift_instantiateWitnessTable directly. 2) For synthesized witness tables that might not be unique, they call swift_getForeignWitnessTable. Extend swift_instantiateWitnessTable() to handle both runtime uniquing (for #2) as well as handling witness tables that don't have a "generic table", i.e., don't need any actual instantiation. Use it as the universal entry point for "get a witness table given a specific conformance descriptor and type", eliminating witness table accessors entirely. Make a few related simplifications: * Drop the "pattern" from the generic witness table. Instead, store the pattern in the main part of the conformance descriptor, always. * Drop the "conformance kind" from the protocol conformance descriptor, since it was only there to distinguish between witness table (pattern) vs. witness table accessor. * Internalize swift_getForeignWitnessTable(); IRGen no longer needs to call it. Reduces the code size of the standard library (+assertions build) by ~149k. Addresses rdar://problem/45489388.
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Fix two typos [NFC]
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Apr 29, 2021
Disable foundation test due to https://github.com/apple/swift-corelib…
This was referenced Jan 21, 2018
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.