Extend URLResponse tests

[matis-schotte]

This is my first rather small contribution to the swift project.
I tried to start with updating/adding a few tests for URLResponse.
Since I am still on High Sierra I was working on the 4.2 branch.

Please let me know if there is anything wrong or things I can do better next time.

[ikesyo]

Let's kicking CI.

@swift-ci Please test.

[matis-schotte]

Yes, I did change it to -1 but going to add the 0 test back in, thanks for the reply!

…

Am 23.03.2019 um 18:08 schrieb Simon Evans ***@***.***>: @spevans commented on this pull request. In TestFoundation/TestURLResponse.swift: > - let url = URL(string: "test")! - let res1 = URLResponse(url: url, mimeType: "text/plain", expectedContentLength: zeroContentLength, textEncodingName: nil) - XCTAssertEqual(res1.expectedContentLength, Int64(zeroContentLength), "should be Int65 of the zero length") - let res2 = URLResponse(url: url, mimeType: "text/plain", expectedContentLength: positiveContentLength, textEncodingName: nil) - XCTAssertEqual(res2.expectedContentLength, Int64(positiveContentLength), "should be Int64 of the positive content length") + + func test_MIMEType_notAvailable() { + let mimetype: String? = nil + let res = URLResponse(url: testURL, mimeType: mimetype, expectedContentLength: 0, textEncodingName: nil) + XCTAssertEqual(res.mimeType, mimetype, "should be the other mimetype") + } + + func test_ExpectedContentLength_positive() { + let contentLength = 100 + let res1 = URLResponse(url: testURL, mimeType: "text/plain", expectedContentLength: contentLength, textEncodingName: nil) + XCTAssertEqual(res1.expectedContentLength, Int64(contentLength), "should be positive Int64 content length") Has the test with zeroContentLength been removed? In general we don't remove tests unless they are invalid and not required anymore, so I would just add back in the zero content length test to this test function. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[matis-schotte]

Could we try the ci-tests again?

[spevans]

@swift-ci test

[ikesyo]

@swift-ci test

[ikesyo]

@swift-ci test

[matis-schotte]

Is it possible that sometimes the CI doesn't execute? Seems it's still waiting for the linux swift test even though the test was triggered a day ago.

[ikesyo]

@swift-ci test

[ikesyo]

Thanks for adding these! ✨