SR-10277: FileManger: Handle invalid filenames including "" more gracefully #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efully. - Add __fileSystemRepresentation(withPath:) which is a throwing version to allow validating filenames and throw if invalid or cannot be converted to FSR. - Update _fileSystemRepresentation<ResultType>(withPath:_:) and _fileSystemRepresentation<ResultType>(withPath:andPath:_:) to throw, and update callers to catch or propagate the error as required. - .attributesOfFileSystem: Call statfs()/statvfs() using the FSR. - NSString.deletingLastPathComponent: Fix crash if string is empty. - Add tests for calling FileManager methods with empty filename and handle the response more gracefully by throwing an exception.
|
@swift-ci test |
|
@swift-ci please test |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add __fileSystemRepresentation(withPath:) which is a throwing version
to allow validating filenames and throw if invalid or cannot be converted
to FSR.
Update fileSystemRepresentation(withPath::) and
fileSystemRepresentation(withPath:andPath::) to throw,
and update callers to catch or propagate the error as required.
.attributesOfFileSystem: Call statfs()/statvfs() using the FSR.
NSString.deletingLastPathComponent: Fix crash if string is empty.
Add tests for calling FileManager methods with empty filename and
handle the response more gracefully by throwing an exception.