Parity: TimeZone.local, TimeZone.timeZoneDataVersion #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add __NSLocalTimeZone; the name is chosen so as to be NSCoding-compatible with Darwin. Make sure NSTimeZone.local and TimeZone.autoupdatingCurrent return it. Implement .timeZoneDataVersion the same way as it is in Darwin. Re-enable the setter for .abbreviationDictionary.
|
@swift-ci please test |
compnerd
reviewed
Apr 10, 2019
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
This was referenced Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
__NSLocalTimeZone; the name is chosen so as to beNSCoding-compatible with Darwin. Make sureNSTimeZone.localandTimeZone.autoupdatingCurrentreturn it.Implement
.timeZoneDataVersionthe same way as it is in Darwin.Re-enable the setter for
.abbreviationDictionary. We'll fix its bugs rather than crashing.Fixes https://bugs.swift.org/browse/SR-10348, https://bugs.swift.org/browse/SR-10349