Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove miscellaneous NSUnimplemented() use #2491

Merged
merged 1 commit into from Aug 27, 2019
Merged

Remove miscellaneous NSUnimplemented() use #2491

merged 1 commit into from Aug 27, 2019

Conversation

millenomi
Copy link
Contributor

  • A custom protocol can now cancel authentication challenges.
  • Marked response dispositions appropriately depending on implementation.
  • PersonNameComponentsFormatter requires Darwin features. Mark it unavailable.
  • Remove comments with NSUnimplemented() calls in them.
  • Removed some uses of NSUnimplemented() that should’ve been actual assertions or NSUnsupported().

@millenomi
Remove miscellaneous NSUnimplemented() use.
68d6912 
 - A custom protocol can now cancel authentication challenges.
 - Marked response dispositions appropriately depending on implementation.
 - PersonNameComponentsFormatter requires Darwin features. Mark it unavailable.
 - Remove comments with NSUnimplemented() calls in them.
 - Removed some uses of NSUnimplemented() that should’ve been actual assertions or NSUnsupported().
@millenomi
Copy link
Contributor Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit 60ae6e8 into apple:master Aug 27, 2019
@millenomi millenomi mentioned this pull request Aug 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@millenomi @swift-ci